Four card feature - HTML/SASS

Community feedback

• 

  Arturo Simon•1,785

  @artimysPosted about 4 years ago

  Hi Enayar, you did great job. You were able to capture the details really well. I do agree with you on a tablet view for the transition from mobile to desktop. I'll add some feedback.

  • Good use of using BEM. I would only suggest adding the --modifer to your class that overwrites the color. Example card__top-color blue_color to card__top-color card__top-color--blue. Though I do admit your method looks much cleaner for this situation.

  Just a note. Be aware of "specificity" when building out your selectors (example below of what I mean). Sometimes when they nest too deep in larger projects. It can be difficult to over override styles and manage. BEM is a way to help know which classes go along with each other which you already have a start on.

  body main .cards .card .card__description {  <-- these guys I'm referring to
  
  }
  

  Great job, keep it up and keep on coding!! 👍

  2

  ---

  

  Rayane•1,935

  @RayaneBengaouiPosted almost 4 years ago

  Thank you @artimys for this feedback ! 🙂

  I recently started to read about BEM methodology and found it very interesting, so I try to use it more and more but I'm not confident yet. Next time I won't forget to use a --modifier.

  For the specificity I totally get your point. But I really like how I can nest everything with SASS because I find it very clean on the "code side" (personnal preference). So do you suggest to nest less so that I can reduce my specificity ?

  I'll take a look on your code to see how you process, thanks again 👍

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Hey, nice work, Enayar! 👍

  Your solution looks good and is responsive! 👏

  Just a tip—I think you can make your HTML is little more semantic by using a <h1> tag for the heading of the page and perhaps some <article> tags for the feature cards. 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Rayane•1,935

  @RayaneBengaouiPosted almost 4 years ago

  Thank you @ApplePieGiraffe for this feedback ! 🙂

  Ho right ! I've never dived into semantic HTML but seems a good idea for a better readability. I'll implement it next time 👍

  0