Four card feature

Community feedback

• 

  P

  Marcus•120

  @marcus-hillPosted about 1 month ago

  Hi @Djamel1133, good work with this! I like your use of flex box in order to create the finished design, which works as one of the multiple ways of completing this challenge.

  Here's some feedback for you:

  • The coloured line at the top of each card appears to have been done differently for the Supervisor card compared to the other three. I would stick to using border-top: to achieve this (as you have done with the Supervisor card), rather than utilising the <hr> element and then sticking a border-top: on top, which overlaps with the border-radius.
  • The box-shadow doesn't appear to match the design brief, it was specifically looking for one on the bottom of each card.
  • It's great you are using responsive CSS units for the margin and font sizes, which scales well with a user's default browser font size.
  • Did you need to make each card itself a flexbox (which you've done by targeting .cards div)? By taking off display: flex on these, the only element out of place is the icon which could then be aligned to the right in another way? The elements in the card are already block elements and so will already stack like a column, questioning whether flexbox was needed.

  Good luck in the future!

  0