Design comparison
Solution retrospective
I'd like to receive feedback on my code :)
Community feedback
- @kadherynaPosted over 3 years ago
Thank you very much for your suggestions! :) I'm glad there is no as much to change as I was afraid of.
0 - @RayaneBengaouiPosted over 3 years ago
Hello Kadheryna,
Congrats for completing this challenge ! 🙂
I'd like to suggest :
-
Your
background-size
property is invalid. Instead of havingbackground-position: top-left, bottom-rigth;
, it should bebackground-position: left top, right bottom;
. There was a typo on "right" and there is no need to add "-" between values. -
Add
min-height : 100vh
to yourbody
. It will make sure that your body covers the entire viewport, thus, your second background image can position bottom right correctly. -
Modify the
font-weight
property of your<h1>
and the text in the reviews to match better the design. -
Use the
max-width
property on your boxes so that they don't overscale on big screens.
Overall, well done for the challenge and happy coding ! 😃
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord