Flexbox, Javascript

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Cornelius! 👋

  Good effort on this challenge! 🎉 Everything works good and responds well. Take a look at:

  • Change the alt attributes for the .header-image, .service-mini-box-image and all sections backgrounds-images, .gallery-boxes-img, as they don't add any extra context for screen reader users. Since your images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.
  • Wrap your .svg-social-icons into anchor elements <a> so they behave like links. Don't forget to add aria-label to them with expected behaviour like "Facebook" etc. It is because screen-readers they won't know what they're clicking since svg is treated like there is no content.
  • Your menu on mobile is open by default. Is that on purpose? If not, remove .menu-bar-open from .menu-bar-ul HTML. (It will be added when user clicks on button).
  • I've published an article (link) on how to create a basic animated hamburger menu button for beginners. Maybe next time you try to do one, instead of leaving the usual picture.

  Good luck with that, have fun coding! 💪

  Marked as helpful

  1

  ---

  

  Cornelius Ogunjeminiyi•115

  @cornelldevPosted over 3 years ago

  @tediko You really checked my code?! Thank you Tediko! You have been most helpful, a million thanks won't do. I'll make these changes and study the link to creating animated hamburger as well, I've always needed it.

  1

  

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  @cornell-ui Have fun! :)

  0
• Account deleted

  First thing I noticed, you used the same picture for each person, don't know why.

  Desktop view works, but down-sizing and getting to smaller screens does not look really good, I think you need to work on responsive design.

  Keep coding👍.

  Marked as helpful

  1

  ---

  

  Cornelius Ogunjeminiyi•115

  @cornelldevPosted over 3 years ago

  @thulanigamtee Thank you for taking the time, I appreciate the encouragement too. I've tried to improve the code, and it surely looks a bit better now!

  0