Skip to content
Submitted over 3 years ago

Flexbox and BEM naming

gsemyong•110
@gsemyong
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...3-column preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I'd really appreciate any feedback, but to how some starting ground will point few things:

Did I follow all the best practices for HTML structuring (what I could've have done to achieve more semantically meaningful HTML)? Did I follow all the best practices regarding BEM naming? What could I improve in my CSS code? Thank you in advance!

Community feedback

  • tediko•6,680
    @tedikoPosted over 3 years ago

    Hello, Gsemyong! 👋

    Good job on this challenge! Your solution responds well and looks nice. When it comes to BEM, you using it correctly. Some tips from me:

    • Since your .card__logo icons images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers.
    • Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.

    Good luck with that, have fun coding! 💪

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord