Four Card Feature Section

Community feedback

• 

  Adriano•42,780

  @AdrianoEscarabotePosted 4 months ago

  Hi SydsBike, how are you doing? I really loved the outcome of your project, but I have a few suggestions that I think might be helpful:

  Avoid using the <br> tag in your HTML code. While <br> might seem like a simple way to break lines, it is considered bad practice and can lead to significant accessibility concerns. For users who rely on screen readers, the presence of <br> can be announced, which disrupts the flow of the content and creates a confusing experience.

  Instead of <br>, you should use semantic HTML to structure your content properly. For example, wrapping text in paragraphs (<p>) or using <div> containers for sections provides a cleaner and more accessible solution. This approach improves usability for screen readers and ensures that your content is presented in a meaningful way to all users.

  For more detailed guidance, refer to the MDN documentation on the <br> tag: MDN: Accessibility Concerns of <br>

  Pro Tip: Accessible web development isn't just a recommendation—it's essential for ensuring inclusivity on the web!

  The rest is excellent.

  I hope you find it useful. 👍

  Marked as helpful

  1

  ---

  

  SydsBike•210

  @SydsBikePosted 4 months ago

  @AdrianoEscarabote Thank you for the feedback!

  I chose to use the line break instead of a <p> because I thought it would be better if classified as an H1 when it came to screen readers and accessibility. I was unaware of the accessibility issues related to the <br> element so I greatly appreciate the information!

  1
• 

  P

  Karsten Løgstrup•160

  @logstrup78Posted 4 months ago

  Nice work. I think the shadow on the cards, are a little bit to dark. I see that you have used the clamp() function in your CSS, I think I need to learn that.

  Marked as helpful

  1