Flex and grid solution with Swiper.js

Community feedback

• 

  Rohith Suresh•65

  @rohith-23-creatorPosted about 3 years ago

  OMG. That's an incredible work. I learnt a lot 👍

  1

  ---

  

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted about 3 years ago

  @rohith-23-creator Thanks so much Rohith! 🙏🏼

  1
• 

  Alex Kim•1,325

  @alex-kim-devPosted over 4 years ago

  Hey Emmilie! That's a really fantastic work! Your solution is pretty accurate compared to the design. Also I like how you structured your SASS - very convenient and simple. I honestly don't know what can be improved, but here is a little hint on using media queries in sass. I noticed you often write @media screen and (min-width: 992px) {}. We can cut a little code here by defining mixins:

  // mdUp means for medium screens (992px) and higher
  @mixin mdUp {
    @media screen and (min-width: 992px) {
      @content;
    }
  }
  

  then we can use it like so:

  .class {
    padding: 1rem;
    @include mdUp {
      padding: 1.5rem;
    }
  }
  

  And that's it. Good luck and I'll see your next project!

  3

  ---

  

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted over 4 years ago

  @Alex-K1m Hi Alex, I agree about the media queries, it’s quite repetitive. I’ll refactor the project. Thanks for the feedback! 🙂

  0

  

  Oliver Sagala•120

  @sagspotPosted almost 4 years ago

  @Alex-K1m I learnt something as well. Thanks Alex

  0

  

  Alex Kim•1,325

  @alex-kim-devPosted almost 4 years ago

  @sagspot You're welcome!

  0
• 

  Kenny Fairris•100

  @kfairrisPosted over 4 years ago

  Wow that’s identical. Great job!

  2

  ---

  

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted over 4 years ago

  @kfairris Thank you!

  0
• 

  Oliver Sagala•120

  @sagspotPosted almost 4 years ago

  Goodness!! This is really identical.

  You find it easier to use CSS to toggle the mobile nav, I thought js makes it easier and cleaner.

  Otherwise, this is really cool stuff

  1

  ---

  

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted almost 4 years ago

  @sagspot Thank you! You can use either methods, just make sure to check for accessibility :-)

  1
• 

  Seokjin Kim•25

  @SukJinKimPosted over 4 years ago

  Wonderful🥳

  1

  ---

  

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted over 4 years ago

  @SukJinKim Thank you!

  0