Design comparison
Solution retrospective
Open to any suggestion to how improve in my code. Thanks
Community feedback
- @ChaffexdPosted about 2 years ago
Hey Tony!
You got it more or less spot on to the design, I like to see that.
I would recommend taking a look at the styles again to ensure you have complete circles whereas I currently see an oval shape.
Nice use of forEach in JavaScript. You could dynamically update the text using JavaScript as well and interpolating the script but the approach you have also works just fine. I would recommend taking a look at my solution if you wanted to explore more of what I meant.
Hope this helps!
Marked as helpful0@tony1610Posted about 2 years ago@Chaffexd Thanks! I see the oval number too and I meant to fixed before submitted, however, I was excited about have my JS working that I forgot to fixed lol. At soon I have a chance, I will fixed and take a close look to your solution. Thanks for the feedback.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord