First Mini Project - QR Code Component

Community feedback

• 

  Rajaul Islam Ratul•1,250

  @ratul0407Posted about 1 year ago

  @jhogben1 congratulations on completing your first ever frontend mentor solution 🎉🎉

  The solution is great😍😍.But there are some things that you might consider changing:

  • You've used rem for setting up font-sizes which really great and a good practice. But you should also consider using rem for other things like widht:320px to width:20rem and for margin and other things as well.

  I hope it was helpful for you👍👍

  Keep up the good work and happy coding my friend🙂🙂

  1

  ---

  

  P

  j-hogben•290

  @j-hogbenPosted about 1 year ago

  @ratul0407 thank you very much for your feedback, it is indeed very helpful!

  Yes, I can see how that would be beneficial, I'll definitely bare this in mind for the future challenges.

  Thank you again for your feedback, all the best for your coding too pal 👍

  1