first challenge using flexbox

Community feedback

• 

  Tommy•30

  @tommymaher15Posted over 3 years ago

  Looks great!

  Did you use the Figma design to find the measurements for this?

  Setting a max width based on the element size on there would do the trick.

  I find working with figma can be tricky and its an ever learning process for me personally at least.

  Keep it up!

  2

  ---

  

  Mari•555

  @ChurrinChurronPosted over 3 years ago

  Hi!

  No, I don't use Figma. I will try to use css grid or play with the measurements to see if I can fix that problem.

  Thanks a lot for the advice!

  1
• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Mari! 👋

  Good job on this challenge! What I can suggest to change is:

  • Since you're familiar with Flexbox try to center your .box container with that. Either wrap your .box div with another wrapper or apply these styles to body:

  display: flex;
  justify-content: center;
  align-items: center;
  

  • Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.
  • Read about media-queries to make your website accessible both on mobile and desktop resolutions. Now your solution only look good on 375px and desktop, nothing between.

  Good luck with that, have fun coding! 💪

  1