Finally! 240 lines of scss and a bit of vanilla javascript.

Community feedback

• 

  Karol Binkowski•1,640

  @GrzywNPosted over 2 years ago

  Great job on the challenge! I have some suggestions regarding your solution:

  • Always make sure to contain alt attribute in <img> tag (even with empty brackets, if image is not that important). It would fix most of your issues with HTML validation and accessibility.

  • I recommend you not to use IDs in your CSS. It's essential to write code which is easy to maintain, expandable and simple to use in other projects. Classes are better for naming your HTML elements, because you can easily use styles from 1 class for other element (you cannot do it with IDs). If you want to organize your connection between HTML and CSS better, you can check out BEM methodology/naming convention. (also it's great with sass/scss and not that difficult).

  Hope this will help you in your future projects. Have a nice day and happy coding!

  1

  ---

  

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  @GrzywN In addition to your wonderful feedback I would like to elaborate on your first bullet point and recommend @sophiakoulen to read up on html semantic tags which will also help with the accessibility issues.

  https://www.w3schools.com/html/html5_semantic_elements.asp

  Secondly in terms of your second bullet point the reason why IDs should not be used unless you want to specifically make multiple instances of the element distinctive is that the styles are not reusable and is only unique to the particular id.

  I hope this helps

  Happy coding 👍

  0
• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey sophiakoulen good job completing this challenge keep up the good work

  Your solution looks great and I cannot seem to find anything that needs to be changed.

  However I noticed you have some accessibility issues

  • images need an alternate text, simply mention the alt attribute and for the value specify a description based on your image.

  In terms of your validation errors, it will be resolved once you fix your accessibility errors

  I hope this helps

  Cheers Happy coding 👍

  0