Submitted about 1 month ago

FAQ accordion with HTML, SCSS and JS

#sass/scss

Mario Graf-Schantl•490

@mariosearchteam

Preview site View code

This is a solution for...FAQ accordion

HTML
CSS
JS

1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Overall im quite happy, but im just learning scss.

What challenges did you encounter, and how did you overcome them?

It took me a while to get a clean solution for the js. At first i switched the SVGs with JS but didn´t liked it. So i used CSS with background images and now just changing the classes. I think this is a more robust and easier to maintain.

What specific areas of your project would you like help with?

If you have any ideas to improve, i would be happy to get them! :)

Community feedback

Daniel 🛸•44,410
@danielmrz-devPosted about 1 month ago
Hello @mariosearchteam!

Congrats on completing the challenge! ✅

Your solution looks great!

I have a suggestion for improvement:

📌 Think about using <main> to wrap your main content instead of <div>.

Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.

This change might not have impact on how your page looks, but it'll make your HTML code clearer and help with SEO and accessibility.

Hope that's helpful!

Keep up the great work!
Marked as helpful
1
Mario Graf-Schantl•490
@mariosearchteamPosted about 1 month ago
@danielmrz-dev

That´s good feedback, thank you!
1

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord