Allways happy to improve, especcially with vue.js.
Feedback for improvement is allways highly appreciated! :)
There are two areas i would love to get some ideas:
I'm proud that I have completed the challenge
However, it took a lot of time because I would often hit roadblocks then put off solving the roadblocks. I will definitely face them as they come next time
Nice solution.
The only things i have noticed is that the people error is only triggered when 0 is typed, but not when the field is empty.
And the reset function could also set the radio buttons back.
Other than that, really good work.
Hi :)
Looks very good in my opinion. Im not familiar with react so i can´t say much about this.
What i noticed tough is that you can not navigate the 1-5 Buttons with Keyboard for accessibility. I had to change my own solution a little bit to achieve this.
You could use buttons or radio options to name to solutions.
I'm glad I used sass/scss on this project.
What challenges did you encounter, and how did you overcome them?I had difficulty with the layout, it still didn't look the way I wanted, but it was the best I could do for now. I also had problems after I uploaded the project to GitHub, because it worked on my PC, but not on the Github page, but I realized I needed to adjust the path.
What specific areas of your project would you like help with?Any suggestions for improvement are very welcome.
Hey :)
good job on this one! Just a few small tipps:
z-index and background color almost killed me!!! welcom any idea and comment have a nice day
Good job on this one! :)
z-index can be tricky because of the so called "stacking context". Once you get your head around this it gets a lot easier.
I highly recommend Kevin Powell for better CSS understanding. In this video he is talking about it: https://www.youtube.com/watch?v=uS8l4YRXbaw
Hi :) Very good solution in my opinion. One alternative way to do the JS validation would be by using a validation library like JustValidate (https://just-validate.dev/).
It is for sure a good training to write it yourself, but it with the library it is way faster to setup and the code is cleaner.
But for sure, this is a bit of a taste question.
Another optimization for accessibility would be to add ARIA elements for users with screenreader.
Nothing really
What challenges did you encounter, and how did you overcome them?As usual, I struggle a bit to achieve a close-to-pixel-perfect design for the layout. I think I can create a responsive layout that works well, but getting the exact pixel measurements across different screen sizes of the original design is always a bit challenging. However, I can feel that I’m getting more used to it and becoming more productive in this area.
What specific areas of your project would you like help with?Everything that could be helpfull, thank you ! :)
Hi :)
In my opinion you are doing a fantastic job regarding pixel exact development.
The only thing i noticed is that the border radius from the image is changing to 0 when you scale from 375px upwards. At 400px screen width for eg. there is no border-radius.
And there are a few redundancies in the CSS file, but im not familiar with react so i can´t say a lot about that.
Great work! :)
