Design comparison
Solution retrospective
Cualquier sugerencia es bienvenida!
Community feedback
- @skyv26Posted almost 3 years ago
Hi! Sergio, I checked your work and I noticed some issues after some testing.
-
Your accordian tabs on click effect the height of your accordian. I mean when any tab clicked then there is slighlty changed in the height of your accordian vertically (card expansion)
-
Your accordian tabs all should close except the current one which user select. It can be done using JAVASCRIPT easily. Although, some developers also did this functionality by using only CSS.
-
By solving your second issue you just need to fix the height of your accordian, in order to solve your first issue as I wrote above.
-
In mobile view, I saw that your design is responsive, but your card is going outside the viewport and it need some margin-top in order to have some nice space for better visibility. There are others method too like flexbox.
I hope you understand and might be my suggestion will help you.
Good Luck
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord