Submitted over 3 years ago
FAQ Accordion Challenge using SASS, Vanilla JS and Flexbox
@rizwanmustafa
Design comparison
SolutionDesign
Solution retrospective
Any feedback is welcome!
Community feedback
- @tedikoPosted over 3 years ago
Hello, Rizwan Mustafa! 👋
This is a really good solution. Well done! I like that your FAQ's hide when you open next one. Few tips from me:
- Try not to repeat your HTML code with image for each arrow. Easier way around is to use pseudo element
::before
on your.card
element. Set it toposition: relative
and your pseudo element asposition: absolute
. Put your image usingcontent: url('image.jpg')
. - The HTML
<hr>
element represents a thematic break between paragraph-level elements i think there is better approach to this line effect.Border
on.card
or maybe some pseudo element?
Have fun coding! 💪
1@rizwanmustafaPosted over 3 years ago@tediko Thanks! Will try to apply these from now on!
0 - Try not to repeat your HTML code with image for each arrow. Easier way around is to use pseudo element
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord