FAQ accordion card using HTML, CSS and JS

Community feedback

• 

  Aakash Verma•6,710

  @skyv26Posted almost 3 years ago

  Hi! Valeria, I saw your design and tested its responsiveness. It is I think my second feedback on your work. I have noticed some issues and they are as following:

  1. Your desktop design is good, but as soon as I opened 3 tabs after another then I saw your accordian height increased from it original.

  2. As I was checking, also I saw that your only current tab needs to open and rest of 'em needs to close automatically, but it wasn't. I highly suggest you to always follow the requirements. As it is mentioned in the Readme provided along with challenge.

  3. After above two issues, I scrolled page up, and I saw that there's white space and If I am not wrong then, you used 100vh. I would suggest you to always remember when height needs 100vh and when 100%. Use view-width or view-height where you sure that your design is not scrollable.

  4. Because of 3rd issue as I wrote above, in mobile view you can also see this clearly while scrolling, there is too much space and because your accordian touching the bottom of screen, it looks little bit BAD

  There are some more work need to make it little bit good. I hope you understand it and soon will fix it.

  Best Wishes

  Marked as helpful

  0

  ---

  

  P

  Valeria Montoya•240

  @ValeriaMontoyaPosted almost 3 years ago

  @skyv26 Hi Aakash, thanks for taking the time to give me feedback 😊. Honestly, I didn't read the README file, so I didn't know how the accordion had to work like, that's my fault haha. You’re right I made some mistakes with sizes, and I’ll fix them for sure. Greetings!

  1
• 

  Dusvy_M•390

  @dovelmPosted almost 3 years ago

  Good job!!!

  1