Design comparison
Solution retrospective
How to structure the code for an e-commerce website with multiple pages and products within single js file. Is using IIFE's or modular patterns scalable?
Community feedback
- @skyv26Posted almost 3 years ago
Hi! Vinit, You did a great job, I mean this is little bit tough challenge and you did it with your knowledge and efforts, I appreciate it. But there are some issues that I noticed please fix 'em all.
-
Your slider when we click on thumbnails image then a black overlayed component appears and you can also see clearly that your image not only current /default one but also others can be see clearly and It need to fix immediately.
-
Your whole layout design needs to little bit bigger, I mean look at your design middle, there is lot of space, try to increase your font in order to fill the gaps.
-
Now come to your mobile view, you have not made it fully responsive and in 375px design, your header contents are not aligned properly. use flexbox align and justify properties in order to fix it.
-
Your slider is not working, other some little more work is needed to make it perfect.
I hope you understand the issues and soon will fix all.
Good Luck
Marked as helpful1@VinitvhPosted almost 3 years ago@skyv26 Hi Aakash, thank you for your appreciation. That's generous of you. I got to know that I have not written js for carousel after submitting. I am fully aware of the shortcomings in this project, will surely try to fix them.
1 -
- @NADS-PROGRAMMERPosted almost 3 years ago
I didn't started this challenge yet, but my idea to that is I am going to use a ReactJS for that.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord