Skip to content
Submitted over 1 year ago

display: flex en el body para comodar el contenedor al medio

Nahuelā€¢40
@NahuelAlejandroBenitez
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Majd Allahamā€¢120
    @Vat123Posted over 1 year ago

    Hi, my congratulations you did a great job šŸŽ‰

    š’šØš¦šž š­š¢š©š¬

    You need to put a landmark in your code simply wrap your code with <main class='container'> landmark instead of <div class="container" The <main> HTML element is intended for the main content (content) of the <body> of the document (page). I hope it was helpful, you are great, keep up the good work

    Marked as helpful
    1
    Nahuelā€¢40
    @NahuelAlejandroBenitezPosted over 1 year ago

    @Vat123 I appreciate your comment, I will take it into account for future projects. sorry my english i use google translate

    0
  • Ecem Gokdoganā€¢9,380
    @ecemgoPosted over 1 year ago

    Some recommendations regarding your code that could be of interest to you.

    • In order to fix the accessibility issues, you need to replace <div class="container"> with the <main> tag. :) You'd better use Semantic HTML, and you can also reach more information about it from Semantic HTML and Using Semantic HTML Tags Correctly.

    • Additionally, each main content needs to start with an h1 element, and also contain only one h1 element. Your accessibility report states the need for one main landmark. So, you need to use a <h1> element in the <main> tag instead of using the <h2> element. You can replace the <h2>Improve your front-end skills by building projects</h2> element with the <h1>Improve your front-end skills by building projects</h1> element.

    Hope I am helpful. :)

    Marked as helpful
    0
    Nahuelā€¢40
    @NahuelAlejandroBenitezPosted over 1 year ago

    @ecemgo I appreciate your comment, I will take it into account for future projects. sorry my english i use google translate

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord