Desktop first, 3-column flexbox block

Community feedback

• 

  Rayane•1,935

  @RayaneBengaouiPosted over 3 years ago

  Hello Maksim Deviatilov,

  Congrats for your first time using media queries ! 🥳

  I'd like to suggest :

  • The last card's color seems a bit off, you use background-color: hsl(179, 94%, 18%) while I think it should be background-color: hsl(179, 100%, 13%).

  • With the media query I would recommend you to look at mobile first concept for building your CSS, it's quite nice to understand how to manage media queries. Here, the problem is that with your media query range if we have a 360px wide phone, then it goes back to your original CSS declaration. So I would remove the min-width from it. The same applies if we are a little bit above (~600px).

  • Use font-style: inherit on your buttons so that they can inherit aswell the font you declared.

  Overall, well done for the challenge and happy coding ! 😃

  1

  ---

  

  Maksim Deviatilov•185

  @maksimcoderPosted over 3 years ago

  Hello, Rayane, thank you for all your comments, I really appreciate them. I've fixed the font-style and background-color problem and will solve the query issue as soon as possible. I'm delighted with the fact that I've found this resource where great people help each other. Thanks a lot and have a nice day!

  1

  

  Rayane•1,935

  @RayaneBengaouiPosted over 3 years ago

  @maksimcoder Your welcome ! Hope to see you soon on another challenge ! 🙂

  And don't forget to update changes on your solution 😉

  0