Design comparison
Community feedback
- @ecemgoPosted over 1 year ago
Some recommendations regarding your code that could be of interest to you.
If you want that this solution is responsive, you can follow these suggestions below.
- If you want to make the card centered both horizontally and vertically, you'd better add flexbox and
min-height: 100vh
to thebody
- For the color of the screen, you can use the recommended color in the body
body { display: flex; flex-direction: column; justify-content: center; align-items: center; min-height: 100vh; background-color: hsl(212, 45%, 89%); }
- If you remove
height
, the card will be responsive
.content { /* height: auto; */ /* inline-size: 340px; */ }
- In addition to that above, in order to make the card responsive and the image positioned completely on the card, you'd better use
width: 100%
for the img
.qr--image { /* width: -webkit-fill-available; */ width: 100%; border-radius: 15px; }
- Finally, you don't need to use
.container
and remove it to avoid repetition
/* .container { width:100%; height:100vh; background-color:hsl(212, 45%, 89%); display: flex; justify-content: center; align-items: center; } */
Hope I am helpful. :)
Marked as helpful0 - If you want to make the card centered both horizontally and vertically, you'd better add flexbox and
- @ashebaniPosted over 1 year ago
Hello there, nice work completing the design, in order to make the QR Code image inside the container, change the width to 100% and it will work perfectly, good luck!
Marked as helpful0 - @pperdanaPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have some additional recommendations for your code that I think you'll find interesting and valuable.
π Add
<main>
tag as semantic HTML in code-
The
<main>
tag is a semantic HTML element that is used to define the main content of a web page. -
The
<main>
tag should be used to wrap the primary content of a web page, such as the main article, section, or body of text.
for example code:
<main> <div class='container'> <h1>Article Title</h1> <p>Article content goes here...</p> ....................... </div> </main>
In the example above, the
<main>
tag is used to wrap the<div>
tag, which contains the primary content of the web page. This tells both human readers and search engines that the content inside the<main>
tag is the most important and relevant content on the page.I hope you found this helpful!
Happy codingπ€
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord