Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

css grid vanilla javascript

@Gopaljajam

Desktop design screenshot for the Tip calculator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please inform me about the error and suggest some method and technologies

Community feedback

Koyun92 330

@Koyun92

Posted

Hello, Nothing's happening when you changing tip value, establish listener for 'change '.Total amount/person isn't correct, need to add tip amount to total. Greetings Koyun

0
Aakash Verma 6,690

@skyv26

Posted

Hi! Gopal, I noticed some issue.

  1. Your Logo image is not visible, reason behind is that you didn't give path correctly use period (.) before / in image path.

  2. Your calculations are not correct.

  3. As per requirement, you did not add error message to calculator.

  4. Text is little bit big in mobile response. In mobile response your whole layout touches the bottom of screen so, give some spacing by adding margin-bottom: 1rem;

Overall Nice!

Keep coding !

0

@Sung-jin-Lim

Posted

CSS wise, you went completely in your own direction. I don't think any feedback needs to be given there. However the JS functions decently, the custom input needs reset when the reset button is clicked, the tip buttons are completely broken.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord