css grid vanilla javascript

Community feedback

• 

  Koyun92•330

  @Koyun92Posted almost 3 years ago

  Hello, Nothing's happening when you changing tip value, establish listener for 'change '.Total amount/person isn't correct, need to add tip amount to total. Greetings Koyun

  0
• 

  Aakash Verma•6,710

  @skyv26Posted almost 3 years ago

  Hi! Gopal, I noticed some issue.

  1. Your Logo image is not visible, reason behind is that you didn't give path correctly use period (.) before / in image path.

  2. Your calculations are not correct.

  3. As per requirement, you did not add error message to calculator.

  4. Text is little bit big in mobile response. In mobile response your whole layout touches the bottom of screen so, give some spacing by adding margin-bottom: 1rem;

  Overall Nice!

  Keep coding !

  0
• 

  Sung Jin lim•120

  @Sung-jin-LimPosted almost 3 years ago

  CSS wise, you went completely in your own direction. I don't think any feedback needs to be given there. However the JS functions decently, the custom input needs reset when the reset button is clicked, the tip buttons are completely broken.

  0