Skip to content
Submitted over 3 years ago

CSS Grid, Flexbox, CSS Custom Properties

Sigma•240
@TrashAlphonse
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Room homepage
  • HTML
  • CSS
  • JS
3intermediate

Design comparison

SolutionDesign

Solution retrospective

The design is great, I really like it :) A useful reference to create a carousel: https://www.w3schools.com/howto/howto_js_slideshow.asp Any feedback is appreciated and happy coding ✨

Community feedback

  • tediko•6,680
    @tedikoPosted over 3 years ago

    Hello, Sigma! 👋

    Good job on this challenge! I would suggest you to:

    • Read again about BEM methodology. You're using modifiers for elements and it is wrong. Modifier is an entity that defines the appearance, state, or behavior of a block or element. For example .hero__content--title should be either .hero__title or if you want to keep your naming convention .hero__content-title / .hero__contentTitle.
    • I believe you forgot change .hero__content on different slides. In design every slide have different content to display.

    Good luck with that, have fun coding! 💪

    1
    Sigma•240
    @TrashAlphonsePosted over 3 years ago

    @tediko Hi, my bad, indeed, the text is different. Unfortunately attentiveness has never been my strongest side 😕 Thanks for pointing this out :) And thanks for the tip regarding BEM technology. Happy coding 🐱‍🚀

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord