Css Gird, Flexbox, Mozilla Dev Tool, Adobe XD, Stackoverflow, CSSTrick

Community feedback

• Account deleted

  Using CSS Grid to solve this challenge is a very good idea and the code is readable but I don't understand the purpose of using the article element as a generic container. Is there a reason behind that?

  There's a fixed width that's causing horizontal overflow; to fix it just change from

  grid-template-columns: 1fr 560px;

  to

  grid-template-columns: 2fr 1.5fr;

  2

  ---

  

  David Mclean•395

  @davuplsPosted over 4 years ago

  I used the 560px cause it's 40 percent of the 1440 if I'm remembering correctly.

  1

  Account deleted

  @davupls oh ok, but it's a relative size container and it's not recommended to use px on that type of container because you lose size control over it and have to start using media-queries validating all possibilities, so in this case, would be better to use fr.

  1
• 

  David Mclean•395

  @davuplsPosted over 4 years ago

  Wow okay let me go check this. Thank you.

  0