CSS FlexBox and Media Queries for the code. PicPick for measurements.

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  👋Hi Jayanth!

  I notice that you have two default branches, which are master and main. Please choose either master or main as your default branch.

  Also, I recommend to merge those branches.

  More feedback:

  • For any decorative images, you should leave the alt="" empty and add aria-hidden="true" to make sure all screen readers will ignore those images. In this case, the music icon is decorative images.
  • Use rem or sometimes em instead of px. It will make sure that the users can control the size of the page based on their needs.

  That's it! Hopefully this is helpful!

  Marked as helpful

  1

  ---

  

  Jayanth•190

  @gjaynir0508Posted about 3 years ago

  @vanzasetia

  1. For the branches: I am using git bash to add files to my remote GitHub repository. In that GitHub repo, I have the default branch as main and I use the following command to add files git push -u origin master which is creating that master branch. Could you please let me know if there is something wrong with that procedure or if there is some better method to directly add the files to the main branch?

  2. For others: I am trying to learn that and will surely implement that. Thank you very much for your detailed feedback.

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  @gjaynir0508 I would recommend to match the default branch name.

  On your terminal set the default branch to main by executing this command.

  git config --global init.defaultBranch main
  

  Marked as helpful

  1

  

  Jayanth•190

  @gjaynir0508Posted about 3 years ago

  @vanzasetia Thank you very much for the solution. I will implement it immediately.

  EDIT: I found the following question on stack overflow which I think is related and can be helpful. Both @vanzasetia 's solution and the below one work quite well.

  https://stackoverflow.com/questions/66673759/git-branch-m-main

  0
• 

  Dharmik_487•1,740

  @Dharmik48Posted about 3 years ago

  Hello,

  Your solution looks really Great! But one thing which is that you can add a transition on hover effects, it will make the experience better!

  Keep up the good work😄.

  Marked as helpful

  1

  ---

  

  Jayanth•190

  @gjaynir0508Posted about 3 years ago

  @Dharmik48 Thank you for the feedback. I will try to implement that.

  0