crowdfunding-product-page with jQuery

Community feedback

• 

  Roc Tanweer•2,500

  @RocTanweerPosted over 3 years ago

  Nice work Sir..! Some suggestions if you would allow me...

  1. Put aria-label into your input fields with no label or name for accessibility issue.
  2. There is an overflow in the overlay when the modal is appearing... maybe put overflow : hidden;

  Hope it helps(Happy Coding...!)

  1
• 

  Rayane•1,935

  @RayaneBengaouiPosted over 3 years ago

  Hello Mehmet Can BOZ,

  Congrats for completing the challenge ! Even if it's a junior challenge I find it pretty tricky 😁

  I'd like to suggest :

  • Add cursor-pointer to your buttons (some have it, but not all) and menu items.

  • If an option has 0 quantity left it should be unclickable. Thus, adding pointer-events: none might be great.

  • Make option selection more intuitive. It's quite hard to select an option because we have to click on the name of it. I think it should work if you click on the radio button and all the container as well. Because you put a cursor: pointer on it, so the user might expect to work this way.

  • Correct how you handle the number of backers. If you select 3 rewards, instead of having 5,010 backers we have 5.01. So there might be a little error on units here.

  Overall, well done for the challenge and happy coding ! 😃

  1
• 

  Mehmet Can BOZ•160

  @MehmetCanBOZPosted over 3 years ago

  Thanks a lot, RocTanweer for your good advice, it helps me a lot. I will fix the project. Happy Coding...

  0
• 

  Mehmet Can BOZ•160

  @MehmetCanBOZPosted over 3 years ago

  Thanks a lot, Rayane, I will take into account your good advice. They are so valuable to improve me. Happy Coding...

  0