Comments Challenge completed via React

Community feedback

• 

  Nick C.•690

  @niemalPosted over 1 year ago

  Hello there,

  This looks pretty solid congratulations! I have a suggestion to make, at least on the mobile version:

  When you click on an upvote button, the button hover-states and remains hovered. You might want to do something about that and remove the hover on mobile or just make it a keyframes animation on mobile.

  Last but not least fixing the accessibility report on this page should also be a fine task to take on.

  Overall solid, love it, keep it up!!!

  Marked as helpful

  1

  ---

  

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  @niemal Agreed, it is very nice. Also good catch on mobile button click-hover states issue.

  @jgreen721 In addition to that, i'd like to suggest to consider improving the voting logic and tie it to the each components state. Currently, there is a state, but it is hanging in the air and not tied to the data of comment data itself. (The one you render from JSON). Also a user should not be able to give more than one like or dislike, as giving 100 likes or -50 likes makes little sense. It might be a bit tricky to build this functionality, but i'd suggest giving this challenge a try :)

  Hope you find this feedback helpful!

  Marked as helpful

  1
• 

  P

  Justin Green•2,770

  @jgreen721Posted over 1 year ago

  Appreciate the feedback and bug finds! Yea I need to always be a bit better on the accessibility portion and think I will clean it up.

  I initially did some 'reaction' restraint logic but took it off figuring why not allow a few more clicks but yea, I just put a global counter in there that will kick in after 8 clicks. As far as persistence I did think about attaching a firebase or something and may end up doing that. I realize there are other manners but ya, I just didn't go the persistence route at this point. It's definitely a good template exercise for it though!

  I did tidy up the bug with a @media and @keyframes adjustment. The animation can sometimes look a little funny but not bad. I then added a boolean so when you can't click anymore all hover-events will/should?? be stripped. lol

  Again appreciate the replies! 🙂

  0