coming-soon-master

Community feedback

• 

  Rayane•1,935

  @RayaneBengaouiPosted over 3 years ago

  Hello Alsir !

  Did you try to import them from google fonts ?

  Also I wonder why you have HTML link tags in your CSS file ?

  Marked as helpful

  1
• 

  Rayane•1,935

  @RayaneBengaouiPosted over 3 years ago

  Also I just realized that in your CSS you use flex properties such as align-self or justify-content but to use them your item must be a flex item declared with display: flex.

  I recommend you read the differences between display properties block, flex, etc... to understand how to use it. There are also plenty of free short videos on youtube to understand quickly how to implement it

  Hope it will help ! 😉

  1

  ---

  

  alsir hamory•640

  @alsirPosted over 3 years ago

  @RayaneBengaoui thank you bro

  0
• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  This doesn't really look like the design. Did you forget to import the font?

  1

  ---

  

  alsir hamory•640

  @alsirPosted over 3 years ago

  @grace-snow i didn't forget but I can't access the font websites recommend in the style guide

  0

  

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  @alsir you can still choose a sans-serif font (and you could even download the font via npm if you wanted). A sans-serif font would be a good start to get it closer to the design.

  The other thing would be to adjust the max-width of content.

  Good luck with it

  1

  

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  In. Fact looking at it again you seem to have the font links right there but in your css file Instead of the head of the html

  1

  

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  The other thing I notice is youre using flexbox properties in css but without setting anything to display flex so they won't do anything. And you seem to be trying to build a whole layout using percentage margins. That will cause problems on.more complex challenges. I recommend for this you either

  • use flexbox with margins in rems (margin auto on the sides) and a max-width on a wrapper/container
  • or display block/inline block, again with some consistent margins and a max-width

  You don't need much more than that for this.

  The items raised in the report are really important to fix too, especially the input label. I Would use aria-label in this case, and also wrap the input and button in a form element.

  1