Coding bootcamp testimonials slider using React and tailwindcss

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Abdulrahman Nasser! 👋

  Good job on this one! Your solution responds well and overall looks good. Here's my suggestions:

  • Add :focus pseudo class to interactive elements like buttons. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Abdulrahman Nasser•260

  @Abdul-coder-makerPosted over 3 years ago

  Thanks @tediko for your feedback. I will add :focus Pseudo class so the outline property is none. Is that good practice?

  0

  

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  @Abdul-coder-maker Take a look at a link I shared in my comment. Everything is described there. If you want to set outline to none you have to provide other style that indicate that focus. Good luck ;)

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  Over all looks really good the only thing I see is the images of the people and the background images behind them are not scaling at the same rates

  1

  ---

  

  Abdulrahman Nasser•260

  @Abdul-coder-makerPosted over 3 years ago

  Thank you @palgramming for your feedback. Yes you are correct. But what can I do to make them scaling at the same rates?

  0

  

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  @Abdul-coder-maker Alll the elements need to be related to the same parent container that is controlling the overall sizing of the group of elements

  0