clipboard-landing-page. Flex

Community feedback

• 

  Fidel Lim•2,775

  @fidellimPosted about 3 years ago

  Hi Berie,

  Great job finishing the project. Just one thing I have noticed on desktop view. You have set your main and footer max-width to 1400px. It doesn't look great for the content of the main as it goes to the left. To solve this issue, you can this to your body tag:

  display: flex; 
  justify-content: center; 
  align-items: center; 
  flex-direction: column;
  

  With this, the main tag will center. Another way to solve this is just removing max-width for main tag as well as footer tag.

  I hope it helps!

  Marked as helpful

  0

  ---

  

  Fidel Lim•2,775

  @fidellimPosted about 3 years ago

  @Berie let me know if it works! If you also have other questions, you can ask :)

  1

  

  Bernardus•1,095

  @BernardusPHPosted about 3 years ago

  @fidellim thank you. I did see a problem. I came across some issues when I put in your code but I did try to fix it but I have to keep the max-width in though. If that is wrong or taboo I will find another way but I tried my best to sort out the problems.

  0

  

  Fidel Lim•2,775

  @fidellimPosted about 3 years ago

  @Artosh-afr That is alright. There are many ways to solve a problem. There is no such thing as one solution only :)

  1
• 

  Rohit Dubey•335

  @rohitdubey1352Posted about 3 years ago

  Design and code are good but, some suggestions from my side is that your write is designed by and coded by something is should be bottom not on top, add some margin in button at left and right as you can see in the given design and the last thing is to add margin in images in mobile devices version. That all and Great design.

  Marked as helpful

  0

  ---

  

  Bernardus•1,095

  @BernardusPHPosted about 3 years ago

  @rohitdubey1352 I think I understand but could you explain "your write is designed by and coded by something is should be bottom not on top" Do you mean I should use margin-bottom and not margin-top?

  0

  

  Rohit Dubey•335

  @rohitdubey1352Posted about 3 years ago

  @Artosh-afr I am saying, u can see at the top "Challenged by Frontend Mentor and coded by your name" is should be bottom(Like in footer).

  0

  

  Bernardus•1,095

  @BernardusPHPosted about 3 years ago

  @rohitdubey1352 thx for the suggestion but personally, I like it at the top.

  0