Design comparison
SolutionDesign
Solution retrospective
I think both design and solution are pretty identical but I'm very interested in what do you think. Any feedback would be very helpful 😃
Community feedback
- @ChamuMutezvaPosted about 3 years ago
Nice work Dusan. Some things to take care of:
- the mobile display looks good up to 400px, then thereafter the presentation breaks. It gets better on desktop again.
- a
main
element is missing in your html - it is another very important html element to have <img src="./images/image-computer.png" alt="Computer image">
, alt values must be descriptive to allow assistive tech users to visualize the message that is being put across. Words likeimage, logo
etc are automatically announced by screen readers and should generally not be included as alt values. What is important is the content of the image, decorative images should havealt=""
. This particular image can be a decorative image.<a href="#" aria-label="svg">
, the aria-labels in the social icons should tell users of the purpose of the link. For eg the image for the facebook svg can bearia-label="facebook page
oraria-label="welcome to our facebook page"
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord