Clipboard landing page with boostrap & CSS Flexbox

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Mansi! 👋

  Good job on this one! Your solution responds well and overall looks good. In addition to great APG feedback here's my suggestions:

  • Change the alt attributes for the .top-container logo, .tracking_img image, .devices image .col-lg-4 icons, as they don't add any extra context for screen reader users. Since your images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.
  • You forgot to remove margin-right from .bt-ios on mobile screen size and this causes that buttons aren't aligned.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  mansi•195

  @mansi05041Posted over 3 years ago

  @tediko thanks for suggestions

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hey there, mansi! 👋

  Well done on this challenge! 👍 Your solution looks pretty good! 🙌

  A few things I'd like to suggest are,

  • Making sure the logos in the logo section towards the bottom of the page don't get squeezed or stretched when the size of the screen changes but maintain their aspect ratio so that they look good.
  • Turning the navigation links in the footer of the page into actual links by wrapping them in anchor tags. Giving them a hover state would be a good idea, too.
  • Adding background-size: cover to the CSS background image in the header of the page so that it covers the entire length of the screen even on extra-large screens.

  Hope those few tips help a little. 😀

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  mansi•195

  @mansi05041Posted over 3 years ago

  @ApplePieGiraffe thanks a lot !!

  0