Clipboard Landing Page/ Full Responsive CSS/HTML only

Community feedback

• 

  Dylan Heslop•1,570

  @dylan-dot-cPosted 4 days ago

  Looking good and responsive as well!

  I see that you have used ids almost everywhere in your HTML code, for design purposes it better to use classes where I think it's generally accepted as a best practice and ids are normally for form control or for using js. Even if it might not seem reusable, still use classes. I actually had that habit when starting out and chose now to use classes for styling and ids for javascript dom manipulation.

  Also the div you have #computer-content-container is a flex container but it isn't aligned center on larger screens as it stays on the left while the rest stays centered. You can just make it justify-content: center and you should be good.

  You can also translate the image a bit to the left to offset it a little from the webpage.

  Other than those you did well, great work!

  2

  ---

  

  Erkant•200

  @erntTt94Posted 4 days ago

  @dylan-dot-c Thank you, i'm using ids when i need to separate an element and classes when i need styles on many elements, but yes i made many ids here insted of clases which i need to work on... Oh for #computer-content-container it needs to be on the left side like in the design.. Thank you very much.

  0

  

  Dylan Heslop•1,570

  @dylan-dot-cPosted 4 days ago

  @erntTt94 okl, but I still suggest that you could add a max-width as if you zoom out on it, everything will be centered but that container will be far on the left, so a max-width can fix that.

  1