Design comparison
Community feedback
- @GrzywNPosted over 2 years ago
Wow, amazing job. You are working hard.
Regarding your solution I have a small tips for you and your future projects:
You used
<section>
tags without headings, it's good to use<div>
in this case, since section tag isn't really semantic (also in this case it's not really a section) and it causes validation issues. You can watch more about it here.Also next time you can try yourself in validating keyboard inputs. For example to make it, so user cannot enter letter, more than one
.
or too big number. You can make it by usinginput type="text"
with JavaSciript andkeydown
eventListeners.Hope this helps! Keep up the great work and have a nice day!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord