lisztomania23• 170
@lisztomania23
Posted
Congratulations on completing your first challenge! 🎉🎉
Your HTML and CSS code looks good but, I have few suggestions:
-
It is a good practice to use HTML semantics, like wrapping the main content of the body in the
main
tag instead of just usingdiv
. -
And, use
rem
units for text instead ofpx
.
Reference:
Why You Should Use rem to Set Font Size in CSS
I've made pull request on your GitHub repository with few tweaks, merge it if you like.
Happy coding! 😊🚀
Marked as helpful
0