Card-Component-Frontend-Mentor

Community feedback

• 

  lisztomania23•170

  @lisztomania23Posted about 1 year ago

  Congratulations on completing your first challenge! 🎉🎉

  Your HTML and CSS code looks good but, I have few suggestions:

  • It is a good practice to use HTML semantics, like wrapping the main content of the body in the main tag instead of just using div.

  • And, use rem units for text instead of px.

  Reference:

  Semantic HTML - web.dev

  Semantic HTML

  Why You Should Use rem to Set Font Size in CSS

  I've made pull request on your GitHub repository with few tweaks, merge it if you like.

  Happy coding! 😊🚀

  Marked as helpful

  0

  ---

  

  Themoonwillbestaywithme•450

  @ZENSE-THAIPosted 12 months ago

  @lisztomania23 thank sir.

  1