Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Card-Component-Frontend-Mentor

@ZENSE-THAI

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@lisztomania23

Posted

Congratulations on completing your first challenge! 🎉🎉

Your HTML and CSS code looks good but, I have few suggestions:

  • It is a good practice to use HTML semantics, like wrapping the main content of the body in the main tag instead of just using div.

  • And, use rem units for text instead of px.

Reference:

Semantic HTML - web.dev

Semantic HTML

Why You Should Use rem to Set Font Size in CSS

I've made pull request on your GitHub repository with few tweaks, merge it if you like.

Happy coding! 😊🚀

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord