Design comparison
SolutionDesign
Solution retrospective
Hey all! 👋
This is my solution to the calculator challenge.
Features:
- I have coded custom evaluator logic for basic expression evaluation. Link to resources that helped me are in the repository readme.
- I have made extensive use of CSS custom properties for the different app themes.
- Keyboard support
Let me know if you find any bugs, especially with the evaluation. Thanks 🙂
Community feedback
- @ChamuMutezvaPosted over 2 years ago
Greetings Abed
- Limit the maximum number the calculator can take, you can not have a calculator that can take numbers as long as the user has the power to click the number buttons
- try the following calculation
0.1 + 0.2
- excellent work, the other calculations are working as expected .
- site is also responsive
Well done
Marked as helpful0@abedfetratPosted over 2 years ago@ChamuMutezva Thanks for the review. Your right I should limit the max number the user can type in. And thanks for pointing out the
0.1 + 0.2
calculation. I have now learned something about Javascript floating point precision.1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord