Calculator app using React and SCSS

Community feedback

• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  Your buttons are great that is how I have mine in the one I am working on. They have great motion

  Well the main thing you should go back and add is Keyboard inputs

  1

  ---

  

  P

  James•340

  @james-work-accountPosted over 3 years ago

  @palgramming Thanks!

  Wow I didn't even consider adding keyboard inputs, that's a great idea.

  0
• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted over 3 years ago

  Hey James, congrats on your submission. Viewing only on mobile here, and I’m getting quite a bit of overflow. Also, when I click one of the symbols (like +, -), the initial digit doesn’t persist. I get a zero in its place instead. Calculation seems correct though 🙂

  1

  ---

  

  P

  James•340

  @james-work-accountPosted over 3 years ago

  @emestabillo Thank you for your feedback! Wiping to 0 when the user presses one of the symbols was an intentional decision; when I wrote it like that I couldn't work out a simpler way to stop it appending to what was already on the screen. Happy to change it if it doesn't make sense from a UX perspective 🙂

  What do you mean by overflow? Are the buttons not responsive to screen size or something? Admittedly I didn't check it on my actual phone yet, I just used the minimum width of the demo image 😬

  1

  

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted over 3 years ago

  @james-work-account Just checked on desktop, looks ok when you toggle device. I get the overflow on ios, both on Safari and Chrome.

  1

  

  P

  James•340

  @james-work-accountPosted over 3 years ago

  @emestabillo iOS is the bane of my frontend existence... I'll work on fixing it, thanks!

  1