built responsive project with HTML5 and CSS3

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  • If you want to make the card centered both horizontally and vertically, you'd better add flexbox and min-height: 100vh to the body

  body {
    /* margin-top: 80px; */
    display: flex;
    flex-direction: column;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
  }
  

  • When you use flexbox in the body, you don't need to use margin in the .container to center the card
  • If you use max-width, the card will be responsive
  • You'd better give padding to give a gap between the content and the border of the card

  .container {
    /* width: 300px; */
    max-width: 300px;
    /* margin: auto; */
    /* margin-bottom: 10vh; */
    padding: 20px;
  }
  

  • You can add margin to text instead of using padding.

  .text p {
    /* padding: 1px 20px 30px 20px; */
    margin-bottom: 20px;
  }
  

  • Finally, if you follow the steps above, the solution will be responsive. You don't need to use media queries and .img and you can remove them

  /* .img{
      width: 90%;
      margin: auto;
      padding-top: 15px;
  } */
  

  Hope I am helpful. :)

  0