Build with scss, flexbox and vanilla javascript

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Farid! 👋

  Congrats on finishing another challenge! 🎉 Your solution looks very good and also responds well. Here's my few tips:

  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.
  • Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.
  • Remove aria-hidden="true" from your social links and instead add aria-label to describe behaviour of that element since it doesn't have any context.

  Good luck with that, have fun coding! 💪

  Marked as helpful

  1

  ---

  

  Farid Fawwaz Rakha Wibowo•285

  @Rakha112Posted over 3 years ago

  Hay @tediko, thankyou so much for your feedback and your tips. I'll give it a try. Thanks :)

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  well at less than 1000px wide screen your email error message is above the notify button and at above 1000px it is below the button at some point I was able to get both to show at once so you need to work on your email validation styling and logic

  Marked as helpful

  1

  ---

  

  Farid Fawwaz Rakha Wibowo•285

  @Rakha112Posted over 3 years ago

  Hay @palgramming thankyou for your feedback, I wasn't aware of that, thanks for pointing it out :)

  0