Design comparison
Solution retrospective
Comments are highly welcome, thank you
Community feedback
- @ringmPosted about 4 years ago
Hi Onyeanuna! Great job completing this challenge, it’s looking really good!
However, there’s an issue with the main img, on small/medium devices it’s ok, but on large devices it grows extremely big and brakes the design! A fast duck-tape solution could be setting a
max-width
so it doesn’t stretch indefinitely. Another solution would be to make some layout adjustments to the whole layout for bigger screens with media queries.Keep coding!
1@Aahil13Posted about 4 years ago@ringm I Will try this out also, I'm grateful for your comment
0 - @just-a-devguyPosted about 4 years ago
For some reason, when I did the site preview, the into image would not scroll. I did check the CSS and it's marked as positioned fix, maybe try using something like grid or flex and have two parent divs, one with the content and one with the image. That way you won't have to worry about the image being fixed on scroll. Hopefully what I said makes sense. Please let me know if it does not.
0@Aahil13Posted about 4 years ago@adluders thank you so much, I will give that a go
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord