Blogr Landing Page Challenge using CSS Flexbox, SASS, Vanilla JS

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Rizwan Mustafa! 👋

  Congrats on finishing another challenge! Happy to see you posting another solutions. Your solution looks very good and also responds well. Here's my few tips:

  • Change the alt attributes for the .logoDiv and .imgDiv images, as they don't add any extra context for screen reader users. Since your images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.
  • Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.
  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Rizwan Mustafa•155

  @rizwanmustafaPosted over 3 years ago

  @tediko Thanks for the suggestions. Will look into the :focus thing soon!

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  Looks Good overall the only thing I like is having to click to open the sub menus and not have the hover opening. I think the click to open will also make your mobile menu easier to navigate also

  1

  ---

  

  Rizwan Mustafa•155

  @rizwanmustafaPosted over 3 years ago

  @palgramming Thanks. I actually added different events depending on the size of the screen. On mobile, it is click and on desktop it is hover.

  0

  

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  @rizwanmustafa ok you are checking for the type of device and I was checking mobile size with a desktop browser small

  0