Design comparison
Community feedback
- @YuliaLantzbergPosted 3 months ago
The code in css contains a lot of standardized tags, that are not used in the current design and html, like : img, picture, video, canvas, svg { display: block; max-width: 100%; }
input, button, textarea, select { font: inherit; }
This can be confusing as for current reading code but mostly for future modifications. In some time if another team member add some code, he can get unexpected results as styles for these features were already predefined. (Like styles of the browser, that we reset usually in the beginning of css file).
Apart of that, I've learnt new properties and methods and reminded of some I've fogot from this code. Like clamp(), overflow-wrap, gap. Thank you.
In general, code for this design is looking overcomplicated, as for me. It makes it harder to read and then to modify when it's needed. But it uses semantic html and media query that great.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord