Design comparison
Solution retrospective
Hope it is close...
What are the best practices to arrange components vertically?
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @revanthv999!
Your solution looks great!
I have a couple of suggestions for improvement:
- First: In order to make your HTML code more semantic, use
<h1>
for the main title instead of<h2>
. Unlike what most people think, it's not just about the size and weight of the text.
š The
<h1>
to<h6>
tags are used to define HTML headings.š
<h1>
defines the most important heading.š
<h6>
defines the least important heading.š Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.- Second: Still about semantic HTML, use
<main>
to wrap the main content instead of<div>
.
All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0@revanthv999Posted 10 months agoThank you @danielmrz-dev. I will definitely work on those.
1 - First: In order to make your HTML code more semantic, use
- @KarimAyman97Posted 10 months ago
hi revanthv999 Great Job !
1- for your question Here are some best practices to arrange components vertically
a) Use block-level elements such as <div>, <section>, <article>, or <p>
b) Use the CSS Flexbox layout for vertical alignment. The flex-direction: column;
c) CSS Grid Layout . Set the grid container's grid-template-rows
2- I have some accessibility and semantics recommendations for you.
try to change
<div class="container">
to a<main class="container">
also each image should have alt attribute which describes the image<img class="profile_photo" src="./assets/images/avatar-jessica.jpeg" alt='avatar-jessica'>
this does not affect your project visually but it improves SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord