@Djamel1133
Posted
Salam... Well done, your code is great but I have some advice:
- Don't use default values in your code like
line-height: 1.5
. - Use variables for font-size, font-weight, colors, etc. Here is an example:
:root {
--font-size-small: 0.875rem;
--font-size-medium: 1rem;
--font-weight-medium: 500;
--font-weight-large: 700;
--spacing-large: 2rem;
--very-dark-cyan: hsl(159, 80%, 10%);
--dark-cyan: hsl(158, 36%, 37%);
}
It is cleaner and more maintainable.
For the rest, it's great. Good job again and I hope this was helpful.