@DylandeBruijn
Posted
Hi @j-hogben,
Your solution looks great, very close to the design specs. I like your use of Tailwind.
A bit of friendly constructive feedback:
I checked out your Git repository and can't find the index.html. Is it possible that you forgot to push that? It's also not recommended to push the node_modules and dist (build) folders to Git. The size of the node_modules folder can get very big, and when other developers clone your repository they can simply run npm install to acquire the necessary packages. A build folder automatically gets generated when you run the build command and is only needed when deploying your project.
Did you have any specific questions or problems you need help with?
Marked as helpful
Hi @DylandeBruijn,
Thank you very much for your feedback.
I didn't realise how much I didn't know about the repo structure, or which directories/files to upload. Your comment helped significantly, I went and did a bunch of research into that process and think I understand it a lot better now!
Thanks for that, I wouldn't have realised otherwise! I did end up butchering the first solution, but learnt a lot for the second solution.
Really appreciate you taking the time to provide that feedback!
