
Design comparison
SolutionDesign
Please log in to post a comment
Log in with GitHubCommunity feedback
- @skyv26
Hi @itsAyush5,
Here’s some feedback and suggestions for your project that could help enhance its quality and maintainability:
Suggestions
-
Use SVG files effectively
- Save your SVG code into a
.svg
file and import it using the<img>
tag. This approach simplifies your HTML code and improves reusability. 🖼️
- Save your SVG code into a
-
Avoid height restrictions unnecessarily
- Unless absolutely essential, avoid fixing the height of containers. Instead, opt for
max-width
rather thanwidth
to make your design more responsive. Here's an updated suggestion:.card { max-width: 256px; background-color: hsl(0, 0%, 100%); padding: 20px; border-radius: 20px; display: flex; flex-direction: column; box-shadow: 223px 223px 223px 223px rgba(0, 0, 0, 0); }
This will allow your layout to adapt better to different screen sizes. 📱💡
- Unless absolutely essential, avoid fixing the height of containers. Instead, opt for
-
Remove commented-out code
- Any commented code that's no longer in use should be removed. It improves readability and reduces unnecessary clutter.
-
Optimize your CSS
- There seems to be potential for reducing the number of CSS lines. For example, combine properties or use shorthand where applicable. This will make your CSS cleaner and easier to maintain. ✂️🎨
Why This Matters
- A clean and responsive design ensures better user experience.
- Keeping your codebase neat and efficient helps in future maintenance and scalability.
Keep up the great work! Let me know if you need help with these changes or anything else. 🚀
Marked as helpful -
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord