Skip to content
Submitted almost 3 years ago

BEM Sass Vanilla JS

Matthew Van Pelt•575
@Mattvp21
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Time tracking dashboard
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

This was a real challenge for me. I'm happy with the way this turned out. However, I know my javascript needs major refactoring. Looking for suggestions on the best ways to do that. Thanks!

-Matt

Community feedback

  • Aakash Verma•6,710
    @skyv26Posted almost 3 years ago

    Hi! Matthew, I saw your code check line no 25 and 26

    You have did below:

    <h1 class="box__head"><p class="box__head--report">Report for</p> Jeremy Robson</h1>

    Never use any element as a child of any heading(h1, h2, h3, h4, h5, h6)

    You can make any element to the child of p tag <p class="box__head"><span class="box__head--report">Report for</span> Jeremy Robson</p>

    I hope you understand.

    Good Luck

    1
    Matthew Van Pelt•575
    @Mattvp21Posted almost 3 years ago

    @skyv26 My mistake! Was figuring out how to handle that knowing that was the title but two different fonts

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord