BEM Methodology and SCSS

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @GabrielAlberini 👋🏻

  I have a couple of suggestion on how to fix the accessibility issues and some other minor ones.

  • In your markup <div class="container-card">...</div> should be <main class="container-card">...</main> and <div class="attribution">...</div> should be <footer class="attribution">...</footer>. These will fix most of your accessibility issues.
  • What comes to tabindex="", as it already suggests in the report, they shouldn't be greater than 0. So you should remove them at all. Don't forget to generate a new repot once you fix these issues.
  • I really like the animation and the overall approach to the design. However, the preview card is for you to see the overall project, there's no need to implement it. It also causes the screenshot to be off. But it's just my opinion 🙃

  I hope this was helpful 👨🏻‍💻 really creative approach to the overall project. Cheers 👾

  Marked as helpful

  0

  ---

  

  GabrielAlberini•60

  @GabrielAlberiniPosted about 3 years ago

  @kens-visuals Thank you for your comments! And for your comments too, I will take them into account. I will try to fix it.

  Sorry for my English, I'm learning haha :)

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @GabrielAlberini don't worry, your English looks good 👌🏻

  0

  

  GabrielAlberini•60

  @GabrielAlberiniPosted about 3 years ago

  @kens-visuals Tanks! (Issues solved. I forgot the main and footer tags. My bad. 🤦‍♂️)

  0
• 

  Fidel Lim•2,775

  @fidellimPosted about 3 years ago

  Hi Gabriel!

  I would just like to say your project looks cool! You even added some assets w/ animation as background. That's some effort! Well done :)

  0

  ---

  

  GabrielAlberini•60

  @GabrielAlberiniPosted about 3 years ago

  @fidellim At first I did not know that the symbols were not part of the design, and then I liked how they were haha Tanks you for your feedback! :)

  1