Skip to content
Submitted about 2 years ago

Basic webpage with QR code using CSS flexbox

Kate Dames•250
@funficient
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Is there any way that I could improve the quality of my code or possibly simplify anything?

Community feedback

  • Fidel Lim•2,775
    @fidellimPosted about 2 years ago

    Hi Kate,

    Congrats on your first Frontend Mentor challenge!

    Just as a suggestion regarding the accessibility report, you can fix that by adding semantic tags such as <section> or <main>. Inside the tag, you can include everything you have written inside your <body> tag.

    You can further have a look at semantic tags here

    Then, you can resubmit your project to check if the warnings are gone.

    Hope it helps!

    0
    Kate Dames•250
    @funficientPosted about 2 years ago

    @fidellim Thanks! I was wondering what all those warnings meant! All fixed up!

    0
  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hi @funficient, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

    👾My rating for this solution: ⭐⭐⭐⭐⭐

    Here you've a really good first solution its everything so good done, one thing you can do to improve it, its to reduce your code by removing unnecessary divs, all you need is a single <main> or <div> to keep all the content inside, and nothing more. The ideal structure is the div and only the image, heading, and paragraph.

    Here’s one example to show can be cleaner this HTML structure:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    To reduce the CSS you can use the direct selector for each element instead of using class this way you have a code even cleaner, for example, you can select everything using the direct selector for (img, h1, and p, main).

    Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

    ✌️ I hope this helps you and happy coding!

    0
    Kate Dames•250
    @funficientPosted about 2 years ago

    @correlucas Thanks so much for the positive feedback and helpful comments. I removed the div. I was wondering about that!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord