Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Basic QR code component

@BrunoZw1

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Panjiβ€’ 2,110

@pperdana

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have some additional recommendations for your code that I think you'll find interesting and valuable.

πŸ“Œ Add <footer> tag as semantic HTML in code

  • The <footer> tag is another semantic HTML element that is used to define the footer section of a web page.

  • The <footer> tag should be used to wrap the content that appears at the bottom of a web page, such as copyright notices, contact information, or links to other pages.

for example code:

<footer class="attribution">
  Challenge by <a href="https://www.frontendmentor.io?ref=challenge" 
  target="_blank">Frontend Mentor</a>. 
  .................................
</footer>

In the example above, the <footer> tag is used to wrap the copyright notice, which is the content that appears at the bottom of the web page. This tells both human readers and search engines that the content inside the <footer> tag is the footer section of the web page.

I hope you found this helpful!

Happy codingπŸ€–

Marked as helpful

0
Ecem Gokdoganβ€’ 9,380

@ecemgo

Posted

Some recommendations regarding your code that could be of interest to you.

  • In order to center the card vertically and horizontally, you'd better add flexbox and min-height: 100vh to the body
body {
  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100vh;
}
  • If you use flexbox in the body, you don't need to use margin in the main to center the card
  • If you use max-width instead of width, the card will be responsive
main {
  /* width: 330px; */
  max-width: 300px;
  /* margin: 50px auto; */
}
  • In addition to that above, in order to make the card responsive and the image positioned completely on the card, you'd better add width: 100% and display: block for the img in this way:
main img {
  /* width: 300px; */
  width: 100%;
  display: block;
  border-radius: 15px;
}

Hope I am helpful. :)

Marked as helpful

0

@BrunoZw1

Posted

@ecemgo thank you so much, it really got better! :)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord