Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Remove the <br> in yiour first p[aragraph All your content can be contained in one div, seperate the text from the image by cgiving the text-content a div. To center a content on a page specify these in the body{min-height: 100vh; display: flex; justify-content: center; align-items:center;} in the first geive a color of white and a padding value: .first-div{ backgroung-color: hsl(); padding: 1em}. give the second div a padding-top and padding-bottom value: second-div{padding:1.5em 0;} Use rem or em as unit for the width, padding , height and margin value , check out this video for more https://youtu.be/pKX7YnkyR8g After the media query, give the body a percentage width value Hope am helpful, HAPPY CODING
Marked as helpful1 - @godmayhem7Posted almost 2 years ago
hey @trevisandaniel your challenge was totally amazing 👏👏,here are some tips to help you better your code; when i went through your code i noticed you only used div-tags, using just div tags in your body-tag for your sections look kinda messy try using other interactive tags like section-tags(<section></section>),main-tag(<main></main>),header-tag(<header></header>),nav-tag(<nav></nav>) and footer-tag(<footer></footer>) these tags are self explanatory and they help out when other people are trying to understand your code better, the rest of your code was okay👌👌, hope this feedback was helpful 👍👍
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord